Enum #109

s-celles · 2016-01-23T08:34:30Z

Try to fix #70

I don't have most boards so some tests are skipped maybe some tests are failing.

Vido · 2016-01-24T00:30:55Z

@scls19fr ,

Thanks for your contribution.

I have some remarks, and they will be pointed on the diff lines.

Vido · 2016-01-24T00:31:54Z

.travis.yml

-install: pip install -qq flake8 pytest pytest-cov tox
+install:
+  - pip install -qq flake8 pytest pytest-cov tox
+  - python setup.py install


Why this is necessary?

Because it's necessary to install dependencies (enum34). So as enum34 is in dependencies of this package, installing package will install dependencies

ok, because you added enum34 to setup.py and to requirements.txt

Moreover it's a way to ensure that this package installs correctly

Vido · 2016-02-19T21:10:20Z

@scls19fr,

Ok, I will test (py2 and py3) your PR, if everything is ok, it might be merged.

I'm not sure if imports like this will work on Python2.7:

--- from grove import GrovePi
+++ from .grove import GrovePi

I'v done some tests:

ValueError: Attempted relative import in non-package

Vido · 2016-02-20T03:21:01Z

@scls19fr,

A question, does you patch supports python3?

I have found 3 problems:

Some tests break in Python3

        self._pin_states = pingo.util.StrKeyDict()
        # All pins start on LOW
        # FIXME: use "LOW" instead of 0
>       for location, pin in iteritems(self.pins):
            self._pin_states[location] = 0 if hasattr(pin, 'state') else None

pingo/ghost/ghost.py:53:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = ItemsView({'7': <DigitalPin @7>, '11': <PwmPin @11>, 'A1': <AnalogPin @A1>, '0': <DigitalPin @0>, '4': <DigitalPin @4>...mPin @9>, 'VCC': <VccPin 5.0V>, '12': <DigitalPin @12>, 'GND': <GroundPin>, '10': <PwmPin @10>, 'A4': <AnalogPin @A4>})

    def __iter__(self):
>       for key in self._mapping:
            yield (key, self._mapping[key])
E           TypeError: iter() returned non-iterator of type 'KeysView'

There are many files were pingo.LOW or pingo.OUT should be replaced. Specially on exemples/
requirements.txt fails on Python3, because wsgiref

Collecting wsgiref==0.1.2 (from -r requirements.txt (line 16))
  Using cached wsgiref-0.1.2.zip
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-build-7zil_kkb/wsgiref/setup.py", line 5, in <module>
        import ez_setup
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

      File "<string>", line 20, in <module>

      File "/tmp/pip-build-7zil_kkb/wsgiref/setup.py", line 5, in <module>

PS: I don't think enum lead to a more elegant API... but ok.

# Blink

import time
import pingo

# Now another import is needed...
+++from pingo import Mode

board = pingo.detect.get_board()
led = board.pins[13]
---led.mode = pingo.OUT
+++led.mode = Mode.OUT

while True:
    led.toggle()
    print(led.state)
    time.sleep(.5)

s-celles · 2016-02-20T08:05:51Z

I don't think that there is Python 3 support for now see #100
So I'm testing with Python 2.7
I think we should first tackle Enum enhancement and after Python 2/3 support.
We can avoid to import Mode and State by exposing all possible modes and states in __init__.py but I haven't done it now to find more easily where code is broken.
Anyway 1 or 2 additional import is not so problematic. On the other side it adds completion which is very useful, especially for beginners.

s-celles · 2016-03-22T09:29:21Z

Any news about this ?

It should fix pingo-io#104 When led was on and user ask led to blink 3 times (for example), led shouldn't be switched off but should fallback to initial state (before blinking)

coveralls · 2016-06-21T05:57:06Z

Changes Unknown when pulling c6bb567 on scls19fr:enum into * on pingo-io:master*.

Python 2/3 support

bf2e4e2

This was referenced Jan 23, 2016

Change 'IN' 'LOW' 'HIGH' to pingo.IN pingo.LOW pingo.HIGH #108

Closed

Adds an lcd 16x2 example that also uses buzzer and buttons #90

Open

Vido reviewed Jan 24, 2016
View reviewed changes

s-celles mentioned this pull request May 20, 2016

Py3k support #45

Closed

s-celles mentioned this pull request Jun 21, 2016

Is there any preview for getting Pingo in Python 3.5 #112

Closed

lamenezes and others added 13 commits June 21, 2016 07:52

Untested (v0.1) implmentation of http board access (pingo-io#68).

21e9a82

adds command-line arguments to specify host and fixes url mapping

5f9eb2f

pingo.iot: Uses bottle instead of flask. Adds mode setup to the server

757f904

Adds HTTPBoard to communicate to iot server using the board API

2b37237

pep8 fixes

f68298b

Adds method pin.is_analog

0857ac0

Fixes the usage of filters on routing

d5aad1a

Improves url handling with HTTPBoard

4721c35

Fixes route in pingo server

ab1f2a5

pep8 fixes

5ea737f

Stop blinking shouldn't always switch off led

7addd83

It should fix pingo-io#104 When led was on and user ask led to blink 3 times (for example), led shouldn't be switched off but should fallback to initial state (before blinking)

Enhance vim config: auto delete trailing spaces

56464b8

Enum for states and modes

c6bb567

s-celles force-pushed the enum branch from e5311d2 to c6bb567 Compare June 21, 2016 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enum #109

Enum #109

s-celles commented Jan 23, 2016

Vido commented Jan 24, 2016

Vido Jan 24, 2016

s-celles Jan 24, 2016

Vido Feb 19, 2016

s-celles Feb 20, 2016

Vido commented Feb 19, 2016

Vido commented Feb 20, 2016

s-celles commented Feb 20, 2016

s-celles commented Mar 22, 2016

coveralls commented Jun 21, 2016

Enum #109

Are you sure you want to change the base?

Enum #109

Conversation

s-celles commented Jan 23, 2016

Vido commented Jan 24, 2016

Vido Jan 24, 2016

Choose a reason for hiding this comment

s-celles Jan 24, 2016

Choose a reason for hiding this comment

Vido Feb 19, 2016

Choose a reason for hiding this comment

s-celles Feb 20, 2016

Choose a reason for hiding this comment

Vido commented Feb 19, 2016

Vido commented Feb 20, 2016

s-celles commented Feb 20, 2016

s-celles commented Mar 22, 2016

coveralls commented Jun 21, 2016